Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce static singleton for NullPlatformSupport #86

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

VISTALL
Copy link
Contributor

@VISTALL VISTALL commented Jul 29, 2024

Since NullPlatformSupport is final, and we can make singleton of it, and replace all usages.

Old constructor deprecated (backward compatibility)

Issue #85

…pport, and replace usage, and deprecate public constructor
@weisJ
Copy link
Owner

weisJ commented Aug 2, 2024

Arguably keeping the old constructor isn't technically necessary as per the module-info file nothing inside the renderer package is exposed. Though keeping in mind how little the module system is actually used still, keeping it is an ok compromise. Thanks for tackling this 👍🏼

@weisJ weisJ merged commit a1da900 into weisJ:master Aug 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants