-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor clang_getUnqualifiedType (#202) #203
Conversation
Build failures! Interesting. Builds and tests pass locally, and I purposefully made the build fail before changing the C code, so I do not think it is a local cache issue. Investigating... |
da75254
to
c7cde23
Compare
Which OS do you use? On Ubuntu at least it's very easy to have multiple
Not strictly needed, CI will check it anyway, and you'll probably not have to deal with different |
Motivation: perform checks in Haskell to take advantage of type safety. * `WrapperResult` is completely factored out. * `ClangVersionError` is added to indicate version support errors. * `InvalidCXTypeError` is added to indicate Haskell-side invalid type errors. * `clang_getUnqualifiedType` (Haskell) is refactored to check the `libclang` version and type validity, removing the checks from `wrap_getUnqualifiedType` (C).
7945c8b
to
5415b88
Compare
I am currently using Arch. Details
At some point, we might want to test against more versions. Debian has packages for many versions (on different distributions), and it should not be difficult to test locally within containers.
I am not sure what the situation is on Ubuntu, used in CI, as Ubuntu Packages Search is returning internal server errors when searching. |
Yes, testing with some older versions especially would be useful, to see if there are any assumptions that we are making that aren't warranted. |
Motivation: perform checks in Haskell to take advantage of type safety.
WrapperResult
is completely factored out.ClangVersionError
is added to indicate version support errors.InvalidCXTypeError
is added to indicate Haskell-side invalid type errors.clang_getUnqualifiedType
(Haskell) is refactored to check thelibclang
version and type validity, removing the checks fromwrap_getUnqualifiedType
(C).