Overhaul treatment of source locations #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edsko
force-pushed
the
edsko/overhaul-locations
branch
6 times, most recently
from
e162566 to
1bcdb83
Compare
We are now much more precise; see discussion of `MultiLoc` in `src/HsBindgen/Clang/Util/SourceLoc/Type.hs` for details.
edsko
force-pushed
the
edsko/overhaul-locations
branch
from
1bcdb83 to
a33dcd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are now much more precise; see discussion of
MultiLocinsrc/HsBindgen/Clang/Util/SourceLoc/Type.hsfor details.Frustratingly,
clang_getSpellingLocationis actually broken prior tollvm-19.1.0(llvm/llvm-project#28205, llvm/llvm-project#72400). However, the new setup does allow us to callclang_tokenizewith the expansion location rather than the spelling location, which is the critical feature we need (similar to the workaround mentioned at llvm/llvm-project#43451).