Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala 2 12 20 #262

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Scala 2 12 20 #262

merged 1 commit into from
Jan 7, 2025

Conversation

paul-butcher
Copy link
Contributor

@paul-butcher paul-butcher commented Jan 6, 2025

What does this change?

This updates scala to get rid of the three big eviction notices that look a bit like this:

org.scala-lang:scala-library:2.12.20 is selected over {2.12.19, 2.12.19, 2.12.19, 2.12.15, 2.12.19, 2.12.19, 2.12.19, 2.12.19, 2.12.19, 2.12.19, 2.12.19, 2.12.19, 2.12.19, 2.12.19, 2.12.8, 2.12.18, 2.12.19, 2.12.15, 2.12.19, 2.12.19, 2.12.19, 2.12.19, 2.12.19, 2.12.19, 2.12.19, 2.12.19, 2.12.19}

2.13 exists above this, but that is currently causing problems and I am trying to isolate that by getting everything else as up to date as possible.

How to test

Look at the comment from GitHub actions on this PR. It doesn't contain the big scary eviction notes mentioned above (org.slf4j is still subject to eviction, but that is currently outside of our control.
)

How can we measure success?

It quietens the above warnings. This makes it easier to spot things that are genuinely concerning.

Have we considered potential risks?

Maybe this is wrong, but as 2.12.20 is already implicitly being used due to the eviction, so the real-world behaviour should be unchanged.

@paul-butcher paul-butcher changed the base branch from main to fix-in-slash-deprecation January 6, 2025 16:38
Copy link

github-actions bot commented Jan 6, 2025

Suspected binary incompatible evictions across all projects (summary)

  • org.slf4j:slf4j-api:2.0.16 is selected over {2.0.7, 1.7.9, 1.7.30, 1.7.30, 1.7.30, 1.7.30}
  • org.slf4j:slf4j-api:2.0.16 is selected over {2.0.7, 1.7.9, 1.7.30, 1.7.30, 1.7.30}
  • org.slf4j:slf4j-api:2.0.16 is selected over {2.0.7, 2.0.9, 2.0.9, 2.0.9, 2.0.9, 2.0.9, 2.0.9, 2.0.9, 2.0.9, 1.7.9, 1.7.30, 1.7.30, 1.7.30}
  • org.slf4j:slf4j-api:2.0.9 is selected over {1.7.9, 1.7.30, 1.7.30, 1.7.30}

See individual evictions stages for more detail

@paul-butcher paul-butcher marked this pull request as ready for review January 6, 2025 16:55
@paul-butcher paul-butcher requested a review from a team as a code owner January 6, 2025 16:55
@paul-butcher paul-butcher merged commit bf9abdc into fix-in-slash-deprecation Jan 7, 2025
93 of 94 checks passed
@paul-butcher paul-butcher deleted the scala-2-12-20 branch January 7, 2025 10:39
@paul-butcher paul-butcher mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants