Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(strict): use standard assert for Node.js legacy versions #761

Merged
merged 5 commits into from
Sep 11, 2024

Conversation

wellwelwel
Copy link
Owner

@wellwelwel wellwelwel commented Sep 11, 2024

Fixes #760.

This approach avoids MODULE_NOT_FOUND in Node.js < 16. Instead, it uses the standard assert.

  • No changes for Bun and Deno.

@wellwelwel wellwelwel changed the title feat(strict): use assert for Node.js legacy versions feat(strict): use standard assert for Node.js legacy versions Sep 11, 2024
@wellwelwel wellwelwel marked this pull request as ready for review September 11, 2024 07:59
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.02%. Comparing base (130dadb) to head (6ad48de).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #761      +/-   ##
==========================================
- Coverage   99.08%   99.02%   -0.06%     
==========================================
  Files          36       36              
  Lines        1742     1742              
  Branches       10       10              
==========================================
- Hits         1726     1725       -1     
  Misses          8        8              
- Partials        8        9       +1     
Flag Coverage Δ
linux 98.96% <100.00%> (ø)
osx 98.96% <100.00%> (-0.06%) ⬇️
windows 98.96% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wellwelwel wellwelwel merged commit d4b7b64 into main Sep 11, 2024
22 checks passed
@wellwelwel wellwelwel deleted the strict branch September 11, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Poku doesn't work on Node.js lower than 16
1 participant