Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: use Buffer to display logs #779

Closed
wants to merge 1 commit into from
Closed

perf: use Buffer to display logs #779

wants to merge 1 commit into from

Conversation

wellwelwel
Copy link
Owner

@wellwelwel wellwelwel commented Sep 17, 2024

Still testing

Slight improvement when displaying large logs.

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.07%. Comparing base (6e73c6d) to head (1b53941).

Files with missing lines Patch % Lines
src/services/write.ts 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #779      +/-   ##
==========================================
- Coverage   99.12%   99.07%   -0.06%     
==========================================
  Files          36       36              
  Lines        1824     1829       +5     
  Branches       10       10              
==========================================
+ Hits         1808     1812       +4     
- Misses          8        9       +1     
  Partials        8        8              
Flag Coverage Δ
linux 98.96% <85.71%> (-0.06%) ⬇️
osx 99.01% <85.71%> (-0.06%) ⬇️
windows 98.96% <85.71%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wellwelwel
Copy link
Owner Author

It would be interesting to bring this change into the private format method. For now, these changes don't bring any real benefits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant