Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate to node parse args #847

Conversation

sirenkovladd
Copy link

use parseArgs from node:util

  • more compact
  • more native
  • more standardized

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.11%. Comparing base (54e82fc) to head (8bf45b3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #847      +/-   ##
==========================================
- Coverage   99.12%   99.11%   -0.01%     
==========================================
  Files          36       36              
  Lines        1825     1818       -7     
  Branches       10       10              
==========================================
- Hits         1809     1802       -7     
  Misses          8        8              
  Partials        8        8              
Flag Coverage Δ
linux 99.00% <100.00%> (-0.01%) ⬇️
osx 99.06% <100.00%> (-0.01%) ⬇️
windows 99.00% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sirenkovladd
Copy link
Author

node 14 and below is not supported

@wellwelwel
Copy link
Owner

wellwelwel commented Nov 11, 2024

Hey, @sirenkovladd. Thanks for the PR and sorry for the delay 🙋🏻‍♂️

node 14 and below is not supported

To maintain backward compatibility and keep Poku free of external dependencies, some functionalities were created from scratch.

In #801, I intend to bump the Node.js version to v12 in order to use ES Modules by default. Unfortunately, parseArgs depends at least on v16.

Regardless, thank you for the proposal and for your efforts in this PR 🤝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants