Merge pull request #76 from wemogy/feature/record-exceptions

Added RecordException to Azure Service Bus Processors
wemogy · Jan 9, 2024 · 0e2facd · 0e2facd
2 parents 8d15b73 + a3a8c84
commit 0e2facd
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/...us/Wemogy.CQRS.Extensions.AzureServiceBus/Processors/AzureServiceBusCommandProcessor`1.cs b/...us/Wemogy.CQRS.Extensions.AzureServiceBus/Processors/AzureServiceBusCommandProcessor`1.cs
@@ -5,6 +5,7 @@
 using Azure.Messaging.ServiceBus;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.DependencyInjection.Extensions;
+using OpenTelemetry.Trace;
 using Wemogy.Core.Errors;
 using Wemogy.Core.Json;
 using Wemogy.CQRS.Commands.Abstractions;
@@ -19,6 +20,7 @@ public class AzureServiceBusCommandProcessor<TCommand> : IAzureServiceBusCommand
         private readonly ServiceBusProcessor _serviceBusProcessor;
         private readonly IServiceCollection _serviceCollection;
         private readonly ScheduledCommandDependencies _scheduledCommandDependencies;
+        private readonly string _handleMessageActivityName;
         private bool _isStarted;
 
         /// <summary>
@@ -41,10 +43,12 @@ public AzureServiceBusCommandProcessor(
             _scheduledCommandDependencies = serviceCollection
                 .BuildServiceProvider()
                 .GetRequiredService<ScheduledCommandDependencies>();
+            _handleMessageActivityName = $"HandleMessageOf{typeof(TCommand).Name}";
         }
 
         public async Task HandleMessageAsync(ProcessMessageEventArgs arg)
         {
+            using var activity = Observability.DefaultActivities.StartActivity(_handleMessageActivityName);
             var services = new ServiceCollection();
             foreach (var serviceDescriptor in _serviceCollection)
             {
@@ -87,8 +91,7 @@ public async Task HandleMessageAsync(ProcessMessageEventArgs arg)
             }
             catch (Exception e)
             {
-                // ToDo: Dead letter message ==> Maybe remove try/catch let AutoComplete manage this
-                Console.WriteLine(e);
+                activity?.RecordException(e);
                 throw;
             }
         }

diff --git a/...gy.CQRS.Extensions.AzureServiceBus/Processors/AzureServiceBusCommandSessionProcessor`1.cs b/...gy.CQRS.Extensions.AzureServiceBus/Processors/AzureServiceBusCommandSessionProcessor`1.cs
@@ -5,6 +5,7 @@
 using Azure.Messaging.ServiceBus;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.DependencyInjection.Extensions;
+using OpenTelemetry.Trace;
 using Wemogy.Core.Errors;
 using Wemogy.Core.Json;
 using Wemogy.CQRS.Commands.Abstractions;
@@ -92,8 +93,7 @@ public async Task HandleMessageAsync(ProcessSessionMessageEventArgs arg)
             }
             catch (Exception e)
             {
-                // ToDo: Dead letter message ==> Maybe remove try/catch let AutoComplete manage this
-                Console.WriteLine(e);
+                activity?.RecordException(e);
                 throw;
             }
         }

diff --git a/...eBus/Wemogy.CQRS.Extensions.AzureServiceBus/Wemogy.CQRS.Extensions.AzureServiceBus.csproj b/...eBus/Wemogy.CQRS.Extensions.AzureServiceBus/Wemogy.CQRS.Extensions.AzureServiceBus.csproj
@@ -19,6 +19,7 @@
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
       <PrivateAssets>all</PrivateAssets>
     </PackageReference>
+    <PackageReference Include="OpenTelemetry" Version="1.6.0" />
   </ItemGroup>
 
   <ItemGroup>