Merge pull request #74 from wemogy/fix/improve-scheduled-command-serv…

…ice-implementation Improved AzureServiceBusScheduledCommandService with ConcurrentDictio…
wemogy · Jan 9, 2024 · dd8bc57 · dd8bc57
2 parents fbad959 + 4a40066
commit dd8bc57
Showing 1 changed file with 6 additions and 8 deletions.
diff --git a/...Wemogy.CQRS.Extensions.AzureServiceBus/Services/AzureServiceBusScheduledCommandService.cs b/...Wemogy.CQRS.Extensions.AzureServiceBus/Services/AzureServiceBusScheduledCommandService.cs
@@ -1,5 +1,5 @@
 using System;
-using System.Collections.Generic;
+using System.Collections.Concurrent;
 using System.Threading.Tasks;
 using Azure.Messaging.ServiceBus;
 using Wemogy.Core.Errors;
@@ -16,23 +16,21 @@ public class AzureServiceBusScheduledCommandService : IScheduledCommandService
         private const string ImmediateMessageJobId = "IMMEDIATE_MESSAGE";
         private readonly ServiceBusClient _serviceBusClient;
         private readonly AzureServiceBusSetupEnvironment _azureServiceBusSetupEnvironment;
-        private readonly Dictionary<string, ServiceBusSender> _serviceBusSenders;
+        private readonly ConcurrentDictionary<string, ServiceBusSender> _serviceBusSenders;
 
         public AzureServiceBusScheduledCommandService(ServiceBusClient serviceBusClient, AzureServiceBusSetupEnvironment azureServiceBusSetupEnvironment)
         {
             _serviceBusClient = serviceBusClient;
             _azureServiceBusSetupEnvironment = azureServiceBusSetupEnvironment;
-            _serviceBusSenders = new Dictionary<string, ServiceBusSender>();
+            _serviceBusSenders = new ConcurrentDictionary<string, ServiceBusSender>();
         }
 
         private ServiceBusSender GetServiceBusSender<TCommand>()
         {
             var queueOrTopicName = _azureServiceBusSetupEnvironment.GetQueueName<TCommand>();
-            if (!_serviceBusSenders.TryGetValue(queueOrTopicName, out var serviceBusSender))
-            {
-                serviceBusSender = _serviceBusClient.CreateSender(queueOrTopicName);
-                _serviceBusSenders.TryAdd(queueOrTopicName, serviceBusSender);
-            }
+            var serviceBusSender = _serviceBusSenders.GetOrAdd(
+                queueOrTopicName,
+                _ => _serviceBusClient.CreateSender(queueOrTopicName));
 
             return serviceBusSender;
         }