Miscfeatures #120
Miscfeatures #120
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -41,6 +41,17 @@ const nextConfig = { | |||
| trailingSlash: false, | |||
| assetPrefix: assetPrefix, | |||
| basePath: basePath, | |||
|
|
|||
| webpack: (config, { isServer }) => { | |||
There was a problem hiding this comment.
genome browser package uses "fs" default file system module of nodejs. Hence I was getting Module not found error. Added below code in next config to resolve this error. Reference (https://stackoverflow.com/questions/64926174/module-not-found-cant-resolve-fs-in-next-js-application)
There was a problem hiding this comment.
Looks good! Thanks for doing this all. Main things are being consistent with where query and type definitions are. We should probably be on the same page with where type and query definitions are put when the type/query is used once vs repeatedly. We have a mix of putting them in separate types/queries.ts files and keeping them where they're used. Not sure what you think is best.
screen2.0/package.json
Outdated
| @@ -42,8 +42,9 @@ | |||
| "@mui/icons-material": "^5.14.3", | |||
| "@mui/lab": "^5.0.0-alpha.137", | |||
| "@mui/material": "^5.14.2", | |||
| "@types/node": "^20.5.0", | |||
| "@types/react": "^18.2.20", | |||
| "@mui/styles": "^5.14.5", | |||
There was a problem hiding this comment.
What depends on @mui/styles? Genome browser?
https://mui.com/system/styles/basics/
Above link says that this is a legacy solution that doesn't officially support React 18. If possible it'd be good to not use it, but if there's no easy workaround let's keep it for now.
There was a problem hiding this comment.
Is it not ideal to have such a huge constants file sitting in the repository? As in would it be ideal to fetch this file versus define it here? I honestly don't know what is best practice for this case. Good for now.
| import React, { RefObject, useEffect, useMemo, useState } from "react" | ||
| import { EmptyTrack } from "umms-gb" | ||
| import { RequestError } from "umms-gb/dist/components/tracks/trackset/types" | ||
| import { ValuedPoint } from "umms-gb/dist/utils/types" |
There was a problem hiding this comment.
umms-gb should ideally be setup to be able to import these without referring to a location deep within the package, but okay for right now.
| ["CTCF", "#00b0d0"], | ||
| ]) | ||
|
|
||
| export const BIOSAMPLE_QUERY = gql` |
There was a problem hiding this comment.
Should these be moved to a queries.ts file?
| ["CTCF-only", "CTCF-only"], | ||
| ]) | ||
|
|
||
| const QUERY = gql` |
There was a problem hiding this comment.
Like other comment, should these live in a dedicated queries.ts file?
| import { useRouter } from "next/navigation" | ||
| export type QueryResponse = [number, string[], any, [string, string, string, string, string, string][], string[]] | ||
|
|
||
| const GENE_AUTOCOMPLETE_QUERY = ` |
There was a problem hiding this comment.
Queries.ts file? Or is it best to define queries where they're used if they're only used once?
|
|
||
| const onSearchChange = async (value: string) => { | ||
| setOptions([]) | ||
| const response = await fetch("https://ga.staging.wenglab.org/graphql", { |
There was a problem hiding this comment.
This url should probably be put in a config file
| import { debounce } from "@mui/material/utils" | ||
| import { useRouter } from "next/navigation" | ||
|
|
||
| const SNP_AUTOCOMPLETE_QUERY = ` |
There was a problem hiding this comment.
Like above comment, maybe put in queries file or leave as is if it's not used elsewhere
There was a problem hiding this comment.
Modifying the genomic region searched for is not working for me. I think it's because Autocomplete's options Array does not contain the modified value so it's value never reflects user changes. Should we look into having a second input for the genomic region to search?
There was a problem hiding this comment.
Try using the "freeSolo" prop on autocomplete as a quick fix. https://mui.com/material-ui/react-autocomplete/#free-solo
There was a problem hiding this comment.
Just a question, is the list of genes for human and mouse identical?
There was a problem hiding this comment.
No. Completely different
No description provided.