Gene expression app & RAMPAGE tab #76
Conversation
… into gene-expression
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Gene Expression app
|
|
Gene Expression Tab
|
There was a problem hiding this comment.
Collape all doesn't work (in https://screen-git-gene-expression-weng-lab.vercel.app/)
There was a problem hiding this comment.
Can we move autocomplete code to different file ?
There was a problem hiding this comment.
Is it possible to move some of code to different components ?
| let drawerHeightTab: number = window.screen.height | ||
|
|
||
| // 1080 | ||
| if (drawerHeight < 1200) { |
There was a problem hiding this comment.
Ideally we shouldn't have manually set height ? @jpfisher72 any thoughts on how this can be done without manually setting height ?
Collapse all does work, default value was not set. worked after closing one. fixed in next commit |
| <line x1={0} x2={900} y1={1} y2={1} stroke="black" /> | ||
| {plotGeneExp(entry, index, 5)} | ||
| </g> | ||
| </svg> |
There was a problem hiding this comment.
The SVGs dont scale well, become tiny on anything but full screen
There was a problem hiding this comment.
we could increase the size of the plots, let's discuss at next scrum
| }) | ||
| }) | ||
|
|
||
| props.range.x.end = max |
There was a problem hiding this comment.
is it possible to not set props.range.x.end ? props are used as readonly variables
No description provided.