Skip to content

Correction to the documentation. #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ashimkapoor wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Correction to the documentation. #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6dc35a
Correction to the documentation.
ashimkapoor Oct 24, 2025
492b83d
Improved upon the correction. Equation 5.2 is where d_k(f) is defined…
ashimkapoor Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions R/multitaperHelper.R
View file
Open in desktop
Copy link
Author

@ashimkapoor ashimkapoor Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, d_k(f) is defined in equation 5.2. |d_k(f)|^2 is the weight in equation 5.3.

Line 75 should read:
## note that the weights are squared, they are |d_k(f)|^2 from equation
## (5.3)

Perhaps I need to do a second PR?

Copy link
Author

@ashimkapoor ashimkapoor Oct 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have done a second commit to perfect this.

Original file line number Diff line number Diff line change
Expand Up @@ -68,11 +68,11 @@
var, dt_, ev, evp=(1-ev),
tol=.03, maxadaptiveiteration=100) {

## this is equation (5.3) and (5.4) form
## this is equation (5.2) and (5.3) from
## Thomson, D.J. Spectrum Estimation and Harmonic Analysis,
## Proceedings of the IEEE, 1982.
## note that the weights are squared, they are |d_k(f)^2 from equation
## (5.4)
## note that the weights are squared, they are |d_k(f)|^2 from equation
## (5.3)

out <- .Fortran("mw2wta", as.double(sa),
wt=matrix(as.double(0), nfreq, nord),
Expand Down