Add robustness to ActiveSnapshot::Config #54
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ility, and robustness Changes include: - Introduced constants for storage methods - Added a custom error class for invalid storage method errors - Refactored predicate methods to reduce code duplication - Enhanced error messages for invalid storage methods
|
I've reviewed this. The only piece of this PR that I am in favor of is: the use of constants for the storage methods. |
| module ActiveSnapshot | ||
| class Config | ||
| class InvalidStorageMethodError < StandardError |
There was a problem hiding this comment.
This error occurs at boot time rather than runtime. So I do not think that we need a specific error class for this.
|
|
||
| SERIALIZED_YAML = 'serialized_yaml' | ||
| SERIALIZED_JSON = 'serialized_json' | ||
| NATIVE_JSON = 'native_json' |
There was a problem hiding this comment.
These constants would need to be frozen too.
There was a problem hiding this comment.
| private | ||
|
|
||
| def storage_method?(method) | ||
| storage_method == method | ||
| end |
There was a problem hiding this comment.
I dont think this was needed. It was very simple in the first place, I would say this is overuse of private methods.
|
Im closing this PR as I am rejecting most of the suggested changes. Please open a new PR if you want to add the constants for the storage methods. |
|
Thx for feedback |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added: Improved ActiveSnapshot::Config for better clarity, maintainability, and robustness
Changes include: