Fix: Hash.fetch(v) resulting in KeyError: key not found: nil
#62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an enum value is set to nil the snapshot creation fails.
| @@ -48,7 +48,7 @@ def metadata=(h) | |||
| def build_snapshot_item(instance, child_group_name: nil) | |||
| attributes = instance.attributes | |||
| attributes.each do |k, v| | |||
| if instance.class.defined_enums.key?(k) | |||
| if instance.class.defined_enums.key?(k) && v.present? | |||
There was a problem hiding this comment.
Suggested change
| if instance.class.defined_enums.key?(k) && v.present? | |
| if v && instance.class.defined_enums.key?(k) |
|
|
||
| assert snapshot_item.object['status'] == 0 | ||
|
|
||
| assert_equal @snapshot.snapshot_items.first.object['status'], snapshot_item.object['status'] | ||
|
|
||
| # Test for enum value nil |
There was a problem hiding this comment.
Can we move this to a separate test case?
| snapshot_item = @snapshot.build_snapshot_item(post) | ||
|
|
||
| assert snapshot_item.object['status'].nil? | ||
| assert_equal @snapshot.snapshot_items.last.object['status'], snapshot_item.object['status'] |
There was a problem hiding this comment.
Why are we asserting on @snapshot.snapshot_items? I think we only need to assert on snapshot_item.object['status'] in these tests?
|
Thanks for the first attempt. However I ended up resolving this in #63 where I made a few tweaks to the code |
|
This bug is fixed in v0.5.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an enum value is set to nil the snapshot creation fails.