chore: Update CImg to 179 because it fixes leaking file descriptors #65
+58,695
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any feedback would have been much appreciated |
|
@route looks like the tests are failing. Those would be worth fixing. |
|
Yea I'll fix them, but over all does it seem like a good idea? |
Details at #23
westonplatter
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I see your archive of pHash-0.9.6.tar.gz has Cimg.h included. I think it's good idea in general to decouple it from there and copy when needed when compile. Also it's an old version of CImg which has a bug of leaking file descriptors resulting in
Too many open files (Errno::EMFILE)which was fixed in 179