Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adjust to make install M1 compatible #85

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dkam
Copy link
Collaborator

@dkam dkam commented Dec 7, 2021

Update the ext code to look in the new Homebrew path on M1

Homebrew on M1 uses /opt/homebrew rather than /usr/local.  This change updates the extconf.rb to point to the correct library location.
Bump the versions
@aledalgrande
Copy link

Is there any blocker to getting this PR merged? Thanks

@westonplatter
Copy link
Owner

westonplatter commented May 17, 2022

Naive question, @aledalgrande what happens for linux users if opt/homebrew/lib does not exist?

PR looks good otherwise. @dkam thanks for including a the version bump along with the changes.

@aledalgrande
Copy link

AFAIK passing an -L option for a path that doesn't exist shouldn't raise an error. Your Travis test should already show that right?

@westonplatter
Copy link
Owner

The library isn't setup to test PRs at this point, so this hasn't been automatically tested within Travis CI, https://travis-ci.org/github/westonplatter/phashion/branches.

@aledalgrande
Copy link

Interesting I thought Travis would build branches by default. Your conf doesn't exclude branches.

@aledalgrande
Copy link

@westonplatter
Copy link
Owner

Score. I don't see a CI Test Suite run for this PR. My guess is the integration needs to get looked at. Any ideas?

@aledalgrande
Copy link

Are you able to log in and add the project in the new travis-ci.com site? Seems like the one you linked is deprecated. I don't have the credentials for the repo so I can't investigate or try to trigger a build.

@westonplatter
Copy link
Owner

yep. Might be a day or two (tied up at work).

@aledalgrande
Copy link

Hey, no worries if you don't have time, but just checking back to put this on your radar.

@westonplatter
Copy link
Owner

TravisCI requires a credit card and will eventually bill for projects after a certain point, therefore, moving to a different free CI. Github Actions seems good enough and was able to get it up and running with minimal copy/paste from examples.

I'd be happy to merge the PR once a rebase on this PR pulls in #88 changes and shows no regressions.

@westonplatter westonplatter changed the title M1 compatible chore: adjust to make install M1 compatible Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants