Fixing multiple accessibility issues #1262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plup2
approved these changes
Oct 7, 2024
plup2
deleted the
1256-aria-reference-exists-but-the-target-for-the-reference-does-not-exist
branch
nschonni
reviewed
Oct 7, 2024
| @@ -210,7 +210,7 @@ if (pr.subTheme === 'eccc') { | |||
| </div> | |||
| <%_ if (pr.siteMenu != false) { -%> | |||
| <%_ if (pr.subTheme == 'esdc' || pr.subTheme == 'labour') { -%> | |||
| <nav role="navigation" id="wb-sm" data-wb-ajax='{"url": "<%- (pr.menuPath != null)? pr.menuPath: '/app/cls/WET/global/<^- msg('esdcmenu-eng.html') ^>' %>", "type": "replace", "nocache": true }' data-trgt="mb-pnl" class="wb-menu visible-md visible-lg" typeof="SiteNavigationElement" aria-labelledby="cdts-topicsMenu"> | |||
| <nav role="navigation" id="wb-sm" data-wb-ajax='{"url": "<%- (pr.menuPath != null)? pr.menuPath: '/app/cls/WET/global/<^- msg('esdcmenu-eng.html') ^>' %>", "type": "replace", "nocache": true }' data-trgt="mb-pnl" class="wb-menu visible-md visible-lg" typeof="SiteNavigationElement" aria-label="cdts-topicsMenu"> | |||
There was a problem hiding this comment.
These changes are incorrect. https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-label
aria-label is for a sting used by the label, and aria-labelledby is used to point to an ID of something that contains the label, like in both cases in this file that were changed
There was a problem hiding this comment.
@ahmad-shahid That's right! Was so focused on the CSS change we had discussed that I missed that :) This should now be text (incl. translation to french)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.