Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding rankMethod parameter to fallback transport #2642

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

0x33dm
Copy link

@0x33dm 0x33dm commented Aug 22, 2024

This is a PR attempting to address the issue highlighted here: #2540

Unfortunately, I didn't get around to running the tests and making it work.

I left a half-written test in there and would appreciate if someone could help writing that test.


PR-Codex overview

The focus of this PR is to add a rankMethod option for custom transport ranking in the fallback system.

Detailed summary

  • Added rankMethod option for custom ranking method in transport fallback
  • Updated rankTransports function to support custom ranking method
  • Implemented custom ranking method usage in transport ranking algorithm

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Aug 22, 2024

⚠️ No Changeset found

Latest commit: ff72608

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Aug 22, 2024

@0x33dm is attempting to deploy a commit to the Wevm Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant