Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade alfajores to op #2714

Closed
wants to merge 6 commits into from
Closed

Conversation

aaronmgdr
Copy link
Contributor

@aaronmgdr aaronmgdr commented Sep 11, 2024

Alfajores will be upgraded from an L1 to an OP L2 at end of the month

This PR adds the relevant contract addresses to the chain definition

(pending review by team)


PR-Codex overview

This PR updates the Celo Alfajores chain configuration to include new contract addresses.

Detailed summary

  • Updated Celo Alfajores chain with new contract addresses
  • Added contracts: portal, disputeGameFactory, l2OutputOracle, l1StandardBridge, l2StandardBridge

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Sep 11, 2024

🦋 Changeset detected

Latest commit: a774762

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
viem Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Sep 11, 2024

@aaronmgdr is attempting to deploy a commit to the Wevm Team on Vercel.

A member of the Team first needs to authorize it.

@@ -1,8 +1,10 @@
import { contracts } from '../op-stack/contracts.js'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for easier review this is

const contracts = {
  gasPriceOracle: { address: '0x420000000000000000000000000000000000000F' },
  l1Block: { address: '0x4200000000000000000000000000000000000015' },
  l2CrossDomainMessenger: {
    address: '0x4200000000000000000000000000000000000007',
  },
  l2Erc721Bridge: { address: '0x4200000000000000000000000000000000000014' },
  l2StandardBridge: { address: '0x4200000000000000000000000000000000000010' },
  l2ToL1MessagePasser: {
    address: '0x4200000000000000000000000000000000000016',
  },
} 

@aaronmgdr
Copy link
Contributor Author

@jcortejoso please review addresses

@aaronmgdr
Copy link
Contributor Author

@tmm I based the contracts on what base / op include in their config. there isn't any reason to have additional contract addresses defined right?

slightly related but would it be correct to add additional celo core contracts to this config?

@tmm
Copy link
Member

tmm commented Sep 17, 2024

there isn't any reason to have additional contract addresses defined right?

Correct, unless they are used internally in Viem. (Can search chain.contracts to see if you missed any.)

slightly related but would it be correct to add additional celo core contracts to this config?

You are welcome to add additional ones that you know will be used downstream, but similar to block explorers/RPC urls, we try to keep things lean when we can!

@aaronmgdr aaronmgdr closed this Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants