Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct spelling of Fahrenheit. #256

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Correct spelling of Fahrenheit. #256

merged 1 commit into from
Dec 30, 2024

Conversation

sjafferali
Copy link
Contributor

@sjafferali sjafferali commented Aug 1, 2024

Fixes #247 and #160.

Noticed the discrepancy in the original trace log:

2024-08-01T20:04:43.432208958Z [2024-08-01T13:04:43 DEBUG govee::hass_mqtt::climate] notify_state for Space Heater Pro (XXXXXXXXX H7133) targetTemperature
642
2024-08-01T20:04:43.432214580Z [2024-08-01T13:04:43 DEBUG govee::hass_mqtt::climate] have: DeviceCapabilityState { kind: TemperatureSetting, instance: "targetTemperature", state: Object {"value": Object {"targetTemperature": Number(75), "unit": String("Fahrenheit")}} }
643
2024-08-01T20:04:43.432796255Z [2024-08-01T13:04:43 DEBUG govee::hass_mqtt::climate] units are reported as Celsius
644
2024-08-01T20:04:43.432804395Z [2024-08-01T13:04:43 DEBUG govee::hass_mqtt::climate] reported temp is 75°C, pref_units: °C
645
2024-08-01T20:04:43.432806817Z [2024-08-01T13:04:43 DEBUG govee::hass_mqtt::climate] setting value to 75.00

@sjafferali
Copy link
Contributor Author

@wez Can you have a look and let me know if anything else is needed to get this in?

@christiandennis
Copy link

Can we get this merged please <3

@wez wez merged commit f85ce39 into wez:main Dec 30, 2024
6 checks passed
@wez
Copy link
Owner

wez commented Dec 30, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants