This repository has been archived by the owner on Jan 5, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
Changes for commity #14
Open
calebxyz
wants to merge
17
commits into
wg21il:master
Choose a base branch
from
regevran:changes_for_commite
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and. added the generated pdf as well
- added tests and header - the func: ready for implementation - fixes after code review - using catch2 as the unit test system
header and tests Co-authored-by: Ran Regev <ran.regev@beyeonics.com>
The Header (3way.hpp) ready for SG9 review Co-authored-by: Ran Regev <Ran.Regev@beyeonics.com>
* implement changes requested at meeting * bug fix * call lexicographical_compare_three_way in its specific namespace
* requirements are ready Co-authored-by: Leeor Saar <Leeor.Saar@beyeonics.com>
* pdf generator seems to be working in a docker Co-authored-by: Ran Regev <Ran.Regev@beyeonics.com> Co-authored-by: Mor Elmaliach <Mor.Elmaliach@beyeonics.com>
* added ranges interface * updated pdf and fixed submodule url * updated pdf * updated pdf --------- Co-authored-by: Ran Regev <Ran.Regev@beyeonics.com> Co-authored-by: Mor Elmaliach <Mor.Elmaliach@beyeonics.com>
- the paper number was changed. P2022 -> D2794 - added some explored directions in the design decision section - fixed typos in the Complexity section
it just seems more correct
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.