Skip to content

Commit

Permalink
Rename get_paginated_generator to just get_paginated
Browse files Browse the repository at this point in the history
We don't care that the function internally uses one, only what it does
  • Loading branch information
rolandgeider committed Jan 16, 2024
1 parent 46e268c commit b3494cb
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 10 deletions.
11 changes: 6 additions & 5 deletions wger/exercises/sync.py
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@
WorkoutLog,
)
from wger.utils.requests import (
get_all_paginated,
get_paginated,
wger_headers,
)
Expand Down Expand Up @@ -165,7 +166,7 @@ def sync_languages(
headers = wger_headers()
url = make_uri(LANGUAGE_ENDPOINT, server_url=remote_url)

for data in get_paginated(url, headers=headers):
for data in get_all_paginated(url, headers=headers):
short_name = data['short_name']
full_name = data['full_name']

Expand All @@ -189,7 +190,7 @@ def sync_licenses(
print_fn('*** Synchronizing licenses...')
url = make_uri(LICENSE_ENDPOINT, server_url=remote_url)

for data in get_paginated(url, headers=wger_headers()):
for data in get_all_paginated(url, headers=wger_headers()):
short_name = data['short_name']
full_name = data['full_name']
license_url = data['url']
Expand Down Expand Up @@ -218,7 +219,7 @@ def sync_categories(
print_fn('*** Synchronizing categories...')
url = make_uri(CATEGORY_ENDPOINT, server_url=remote_url)

for data in get_paginated(url, headers=wger_headers()):
for data in get_all_paginated(url, headers=wger_headers()):
category_id = data['id']
category_name = data['name']

Expand All @@ -243,7 +244,7 @@ def sync_muscles(
print_fn('*** Synchronizing muscles...')
url = make_uri(MUSCLE_ENDPOINT, server_url=remote_url)

for data in get_paginated(url, headers=wger_headers()):
for data in get_all_paginated(url, headers=wger_headers()):
muscle_id = data['id']
muscle_name = data['name']
muscle_is_front = data['is_front']
Expand Down Expand Up @@ -278,7 +279,7 @@ def sync_equipment(

url = make_uri(EQUIPMENT_ENDPOINT, server_url=remote_url)

for data in get_paginated(url, headers=wger_headers()):
for data in get_all_paginated(url, headers=wger_headers()):
equipment_id = data['id']
equipment_name = data['name']

Expand Down
7 changes: 4 additions & 3 deletions wger/nutrition/sync.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,12 @@
DOWNLOAD_INGREDIENT_WGER,
)
from wger.utils.requests import (
get_paginated_generator,
get_paginated,
wger_headers,
)
from wger.utils.url import make_uri


logger = logging.getLogger(__name__)


Expand Down Expand Up @@ -166,7 +167,7 @@ def download_ingredient_images(
url = make_uri(IMAGE_ENDPOINT, server_url=remote_url, query={'limit': 100})

print_fn('*** Processing ingredient images ***')
for image_data in get_paginated_generator(url, headers=headers):
for image_data in get_paginated(url, headers=headers):
image_uuid = image_data['uuid']
print_fn(f'Processing image {image_uuid}')

Expand Down Expand Up @@ -200,7 +201,7 @@ def sync_ingredients(
print_fn('*** Synchronizing ingredients...')

url = make_uri(INGREDIENTS_ENDPOINT, server_url=remote_url, query={'limit': API_MAX_ITEMS})
for data in get_paginated_generator(url, headers=wger_headers()):
for data in get_paginated(url, headers=wger_headers()):
uuid = data['uuid']
name = data['name']

Expand Down
4 changes: 2 additions & 2 deletions wger/utils/requests.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ def wger_headers():
return {'User-agent': wger_user_agent()}


def get_paginated(url: str, headers=None):
def get_all_paginated(url: str, headers=None):
"""
Fetch all results from a paginated endpoint.
Expand All @@ -49,7 +49,7 @@ def get_paginated(url: str, headers=None):
return results


def get_paginated_generator(url: str, headers=None):
def get_paginated(url: str, headers=None):
"""
Generator that iterates over a paginated endpoint
Expand Down

0 comments on commit b3494cb

Please sign in to comment.