Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make __main__ use pyinvoke Program as entrypoint #1833

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

eyJhb
Copy link
Contributor

@eyJhb eyJhb commented Dec 5, 2024

This is conforms more to the recommended way of making a pyinvoke project.
Inspiration was generally taken from fabric, e.g. https://github.com/fabric/fabric/blob/main/tasks.py, which gives a good example of this.

This change is required for packaging for e.g. nix, as the other method called the invoke binary, which changes how paths works. Now it's all contained INSIDE this project, and doesn't call external binaries.

Should be good to go. Hopefully.

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Added yourself to AUTHORS.rst

eyJhb added 2 commits December 5, 2024 22:22
This is conforms more to the recommended way of making a pyinvoke
project.
@rolandgeider rolandgeider merged commit e1a727f into wger-project:master Dec 5, 2024
8 checks passed
@rolandgeider
Copy link
Member

merged, thanks

@eyJhb
Copy link
Contributor Author

eyJhb commented Dec 6, 2024 via email

@rolandgeider
Copy link
Member

I had tne branch already checked out, so I just fixed it. In any case the code would be auto linted once it landed on master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants