Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another bench fix #72

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Another bench fix #72

merged 1 commit into from
Aug 8, 2024

Conversation

RDruon
Copy link
Contributor

@RDruon RDruon commented Aug 8, 2024

No description provided.

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.08%. Comparing base (c6df20b) to head (9f584dd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #72      +/-   ##
==========================================
- Coverage   92.10%   92.08%   -0.02%     
==========================================
  Files          41       41              
  Lines        5182     5182              
  Branches     5182     5182              
==========================================
- Hits         4773     4772       -1     
  Misses        372      372              
- Partials       37       38       +1     
Flag Coverage Δ
2_14_0_ddn133 35.26% <ø> (ø)
2_14_0_ddn145 36.01% <ø> (ø)
all-tests 92.08% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RDruon RDruon force-pushed the rdruon/fix_benchmark2 branch 3 times, most recently from 9f584dd to 4ae7941 Compare August 8, 2024 15:08
Copy link

github-actions bot commented Aug 8, 2024

Benchmark for c57eaaa

Click to view benchmark
Test Base PR %
jobstats 100 4.1±0.77ms 4.3±0.79ms +4.88%
jobstats 1000 41.5±7.48ms 40.5±6.72ms -2.41%

@RDruon RDruon marked this pull request as ready for review August 8, 2024 15:12
@RDruon RDruon requested a review from jgrund as a code owner August 8, 2024 15:12
Copy link

github-actions bot commented Aug 8, 2024

Benchmark for b0577ec

Click to view benchmark
Test Base PR %
jobstats 100 4.3±0.84ms 4.2±0.91ms -2.33%
jobstats 1000 43.0±8.07ms 41.0±7.62ms -4.65%

@jgrund jgrund merged commit 4ef4537 into main Aug 8, 2024
12 checks passed
@jgrund jgrund deleted the rdruon/fix_benchmark2 branch August 8, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants