Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for child #75

Merged
merged 3 commits into from
Aug 14, 2024
Merged

Wait for child #75

merged 3 commits into from
Aug 14, 2024

Conversation

RDruon
Copy link
Contributor

@RDruon RDruon commented Aug 14, 2024

Wait for child to avoid process ID exhaust, see https://doc.rust-lang.org/std/process/struct.Child.html#warning

@RDruon RDruon self-assigned this Aug 14, 2024
@RDruon RDruon requested a review from jgrund as a code owner August 14, 2024 13:41
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 91.66%. Comparing base (9633362) to head (a260bb0).
Report is 1 commits behind head on main.

Files Patch % Lines
lustrefs-exporter/src/main.rs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
- Coverage   91.77%   91.66%   -0.11%     
==========================================
  Files          41       41              
  Lines        5201     5207       +6     
  Branches     5201     5207       +6     
==========================================
  Hits         4773     4773              
- Misses        391      397       +6     
  Partials       37       37              
Flag Coverage Δ
2_14_0_ddn133 35.26% <ø> (ø)
2_14_0_ddn145 36.01% <ø> (ø)
all-tests 91.66% <0.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Benchmark for 2eb784e

Click to view benchmark
Test Base PR %
jobstats 100 4.0±0.56ms 4.3±0.83ms +7.50%
jobstats 1000 39.6±4.97ms 41.0±7.33ms +3.54%

Copy link
Member

@jgrund jgrund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to await both the response and the child at the same time.

Signed-off-by: Joe Grund <jgrund@whamcloud.io>
Copy link

Benchmark for 594e422

Click to view benchmark
Test Base PR %
jobstats 100 4.2±0.64ms 4.1±0.63ms -2.38%
jobstats 1000 42.6±5.78ms 39.1±5.19ms -8.22%

@jgrund jgrund merged commit 34615b1 into main Aug 14, 2024
12 of 14 checks passed
@jgrund jgrund deleted the rdruon/wait_for_child branch August 14, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants