Make result printer compatible with phpUnit version 7 #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimigrunge
commented
Jan 24, 2019
jimigrunge
commented
- Fixed parameter type hinting
- Fixed void returns
- Updated composer settings
- Updated phpunit xml config to v7
- Fixed parameter type hinting - Fixed void returns - Changing composer settings - Updated phpunit xml config
|
Looks good to me, please merge :-9 |
Contributor
|
PHPUnit 7 support is here https://github.com/JeroenDeDauw/nyancat-phpunit-resultprinter |
|
Thanks @JeroenDeDauw! I'm using your fork <3 May you update it to work with PHPUnit 9 as well? |
Contributor
|
I just made a new release that adds compat with PHPUnit 8. Getting PHPUnit 9 to work looks rather involved and I do not currently have the time to spend on that. Pull requests welcome though! |
|
@JeroenDeDauw May you enable issue creation on your Fork, so we can continue there? |
Contributor
|
Huh. Did not realize those where disabled. Here you go: https://github.com/JeroenDeDauw/nyancat-phpunit-resultprinter/issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.