Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add windows-936-2000 as label for GBK #341

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

annevk
Copy link
Member

@annevk annevk commented Feb 13, 2025

Fixes #295.

  • At least two implementers are interested (and none opposed):
    • WebKit
  • Tests are written and can be reviewed and commented upon at:
  • Implementation bugs are filed:
    • Chromium: …
    • Gecko: …
    • WebKit: …
    • Deno: …
    • Node.js: …
  • MDN issue is filed: N/A
  • The top of this comment includes a clear commit message to use.

(See WHATWG Working Mode: Changes for more details.)


Preview | Diff

@annevk
Copy link
Member Author

annevk commented Feb 13, 2025

@hsivonen do you still support this? @inexorabletash?

@inexorabletash
Copy link
Member

It looks like this alias was removed from Chromium circa 2022. https://issues.chromium.org/issues/40130464

@ricea may have thoughts here

@hsivonen
Copy link
Member

My comment on #295 still generally holds: I'm not against this, but I'm more interested in expanding support for Java 1.0 labels (except the pattern found to be Web-incompatible by Presto-era Opera), but I'm also not volunteering to research their Web compat status. I meant to r+ this yesterday, but given the removal from Chromium, I'm now interested in hearing @ricea 's report of how that experience went. If the removal from Chromium was uneventful, perhaps we don't need this.

@ricea
Copy link
Collaborator

ricea commented Feb 14, 2025

No-one cared enough about the removal of windows-936-2000 from Chrome to figure out how to file a bug, and I can't find any complaints about it on the web either. It leads me to believe that there is low value in it.

@hsivonen
Copy link
Member

Thanks. I suggest we wontfix this to avoid churn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Consider adding windows-936-2000 as a label for GBK
4 participants