Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple import maps #10528

Open
wants to merge 60 commits into
base: main
Choose a base branch
from
+460 −82
Open

Multiple import maps #10528

Changes from all commits
Commits
Show all changes
60 commits
Select commit Hold shift + click to select a range
e9a9114
Enable multiple import maps - resolved module set
yoavweiss Jul 28, 2024
c61cd9b
Drawing out plans
yoavweiss Jul 28, 2024
a74611c
Got a few module resolution changes
yoavweiss Jul 29, 2024
410eb03
Setting the resolved URL on Module Script
yoavweiss Jul 29, 2024
b6382dc
Made some progress in the merge algo
yoavweiss Jul 29, 2024
eb5e141
Complete with TODOs
yoavweiss Jul 30, 2024
2e1d13d
conformance issues
yoavweiss Jul 30, 2024
ccd127f
moar conformance fixes
yoavweiss Jul 30, 2024
104942f
Ensure that the importmap validation in "create a JS module script" m…
yoavweiss Jul 30, 2024
079b12c
Fix linking to set iterate and remove
yoavweiss Jul 30, 2024
c573fa0
Address some review comments
yoavweiss Aug 1, 2024
5d049e4
A few more review comments
yoavweiss Aug 1, 2024
b4cc024
Add examples
yoavweiss Aug 1, 2024
032ed8a
Fix up conformance issue
yoavweiss Aug 1, 2024
7c2157f
Fix up algorithm phrasing
yoavweiss Aug 1, 2024
1e0ef76
More review comment fixes
yoavweiss Aug 2, 2024
fb741c4
Fix up the merge algorithm and add integrity handling
yoavweiss Aug 2, 2024
ea2f6cd
Fixed integrity map threading
yoavweiss Aug 2, 2024
e2b4c57
Remove no longer needed assert
yoavweiss Aug 2, 2024
bb2eabf
More review comments
yoavweiss Aug 5, 2024
9aef3cf
Revert the HostGetImportMetaProperties changes
yoavweiss Aug 5, 2024
1927bf8
Modified algorithms
yoavweiss Aug 5, 2024
88a8fef
Pass importMap to fetch descendants
yoavweiss Aug 5, 2024
4da464e
No optional import maps
yoavweiss Aug 6, 2024
b955f2e
Avoid mutating newImportMap
yoavweiss Aug 6, 2024
3c9c5b7
do not add the module from an inline module graph. fix typo
yoavweiss Aug 8, 2024
858b575
Revert calls to settingsObject
yoavweiss Aug 30, 2024
f5ef3cf
Remove asserts
yoavweiss Aug 30, 2024
08e862b
More review comments
yoavweiss Aug 30, 2024
7678447
revamped the merge algo
yoavweiss Sep 2, 2024
82981ab
Revamp fix ups
yoavweiss Sep 2, 2024
7154361
Address a couple more review comments
yoavweiss Sep 2, 2024
8dd3a2f
Ensure prefix and specifier are normalized RE the resolved set
yoavweiss Sep 2, 2024
e5ff9b2
Remove TODO
yoavweiss Sep 2, 2024
458c7ca
Tighten up the add module to resolve module set algorithm
yoavweiss Sep 3, 2024
467608f
Move no-longer-relevant comment
yoavweiss Sep 3, 2024
cb3cda3
clean up the merge algo
yoavweiss Sep 3, 2024
951693e
Modify example and address prefix conflicts
yoavweiss Sep 9, 2024
8d68662
Remove rebase leftovers
yoavweiss Sep 9, 2024
a03c053
Remove more leftovers
yoavweiss Sep 9, 2024
74e4306
Move specifier prefixes above referring URL check
yoavweiss Sep 10, 2024
45efa61
Add examples to cover exact match and all impacting rules
yoavweiss Sep 10, 2024
5217efe
Add dev console logs
yoavweiss Sep 10, 2024
4df4875
Add more console warnings
yoavweiss Sep 11, 2024
54da0ca
Stop piping through the import map
yoavweiss Sep 12, 2024
2cb1fff
Call the prefixes on scope rules as well
yoavweiss Sep 12, 2024
bd1b6a0
Only bail after prefixes
yoavweiss Sep 12, 2024
6e2786f
Deoptimize the algorithm
yoavweiss Sep 16, 2024
d609096
Add note
yoavweiss Sep 17, 2024
13cb290
Remove find url prefixes
yoavweiss Sep 17, 2024
3fbead8
Address some review comments
yoavweiss Sep 30, 2024
a1a0918
Rename pair
yoavweiss Sep 30, 2024
82b5d5c
Mirror the resolution algorithms
yoavweiss Sep 30, 2024
ed308b1
annevk review comments
yoavweiss Oct 4, 2024
7a7edaf
Review comments
yoavweiss Oct 5, 2024
554a268
Add note on asURL and rename specifier
yoavweiss Oct 6, 2024
79147e5
more review comments
yoavweiss Oct 7, 2024
ddc5790
rename base URL to serialized base URL
yoavweiss Oct 7, 2024
9f5fa4f
Remove "threaded through" note
yoavweiss Oct 16, 2024
dd0ff09
Move "add module to resolve set" after we know it resolves
yoavweiss Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading