Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: clean up small parts of sequential focus navigation #10632

Merged
merged 5 commits into from
Oct 2, 2024

Conversation

domfarolino
Copy link
Member

@domfarolino domfarolino commented Sep 18, 2024

The sequential focus navigation infrastructure could likely use a major revamp, to make it more algorithmic, and to deal with data structures more directly instead of the many various "conditions" that describe data structures. Before this is accomplished, this PR cleans up some low-hanging fruit by:

  • Getting rid of confusing concepts like "home document" and "home sequential navigation focus order" which are definitions that appear mid-algorithm, and are likely not necessary in general
  • Clean up implicit flag-like variables by making them more explicit enums
  • Clarifying algorithm parameter types and return types
  • Clean up wrapping
  • Specifying that the "DOM" selection mechanism entails tree order
  • Clean up recursive invocations of the sequential navigation search algorithm

/interaction.html ( diff )

@domfarolino domfarolino marked this pull request as ready for review September 18, 2024 16:11
source Show resolved Hide resolved
@domfarolino domfarolino requested review from domenic and removed request for annevk September 19, 2024 13:28
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big remaining question is tree order vs. shadow-including tree order. Otherwise, loving the cleanups and clarity improvements here.

source Show resolved Hide resolved
source Show resolved Hide resolved
source Show resolved Hide resolved
@domenic domenic added clarification Standard could be clearer topic: focus labels Oct 2, 2024
@domfarolino domfarolino merged commit 0639fee into main Oct 2, 2024
2 checks passed
@domfarolino domfarolino deleted the remove-home-document-things branch October 2, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarification Standard could be clearer topic: focus
Development

Successfully merging this pull request may close these issues.

2 participants