Add FileList interface to HTML. #10693
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This interface really only exists for usage by DataTransfer and <input type=file>, and its interface is driven by how it is (or should be used) by those. As such, it makes more sense to be part of HTML rather than FileAPI, as discussed at TPAC.
|
I think the build errors are because FileAPI still defines this type? Or I might be doing something wrong... |
domenic
reviewed
Oct 11, 2024
| are:</p> | ||
|
|
||
| <ol> | ||
| <li><p>Set <var>serialized</var>.[[Files]] to an empty <span>list</span>.</p> |
There was a problem hiding this comment.
Nit: single-space indents, here and below.
| <ol> | ||
| <li><p>Set <var>serialized</var>.[[Files]] to an empty <span>list</span>.</p> | ||
|
|
||
| <li><p><span data-x="list iterate">For each</span> <var>file</var> in <var>value</var>, append |
There was a problem hiding this comment.
You should loop through value's file list, here and below.
| <li><p>Let <var>files</var> be <span>this</span>'s <span>files list</span>.</p></li> | ||
|
|
||
| <li><p>If <var>index</var> is greater than or equal to the <span data-x="list size">size</span> | ||
| of <var>files</var>, return null.</p></li> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This interface really only exists for usage by DataTransfer and
<input type=file>, and its interface is driven by how it is (or shouldbe used) by those. As such, it makes more sense to be part of HTML
rather than FileAPI, as discussed at TPAC.
(See WHATWG Working Mode: Changes for more details.)
💥 Error: Wattsi server error 💥
PR Preview failed to build. (Last tried on Oct 10, 2024, 8:30 PM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 Wattsi Server - Wattsi Server is the web service used to build the WHATWG HTML spec.
🔗 Related URL
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.