Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Use the right "active document" definition in a focus algorithm #9498

Conversation

rakuco
Copy link
Member

@rakuco rakuco commented Jul 7, 2023

The "currently focused area of a top-level traversable" algorithm was referencing the "active document" associated with a browsing context rather than the one associated with a navigable.


/interaction.html ( diff )

Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find, thanks!

Can you make your membership in the Intel GitHub organization public, to appease the IPR bots? See https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-your-membership-in-organizations/publicizing-or-hiding-organization-membership for more.

@rakuco rakuco force-pushed the editorial-reference-the-right-active-document-dfn branch from e983f09 to 023ceb6 Compare July 11, 2023 12:48
@rakuco
Copy link
Member Author

rakuco commented Jul 11, 2023

Can you make your membership in the Intel GitHub organization public, to appease the IPR bots?

Whoa, I didn't know my membership was private in a bunch of organizations!

In any case, looking at the new failure I seem to be signed up to work on other WHATWG specs like WebIDL but not HTML :( I'll try to solve this internally (and it will probably take a long time) and will get back here once everything's done.

…rithm

The "currently focused area of a top-level traversable" algorithm was
referencing the "active document" associated with a browsing context rather
than the one associated with a navigable.
@rakuco rakuco force-pushed the editorial-reference-the-right-active-document-dfn branch from 023ceb6 to 1ce008f Compare August 8, 2023 15:48
@rakuco
Copy link
Member Author

rakuco commented Aug 8, 2023

@domenic I've finally been added to the right group. The pull request is ready to land at last!

@domenic domenic merged commit 0593c91 into whatwg:main Aug 9, 2023
1 check passed
@rakuco rakuco deleted the editorial-reference-the-right-active-document-dfn branch August 9, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants