Skip to content

Commit

Permalink
Merge pull request #124 from whereby/holvik/fix_build_warnings
Browse files Browse the repository at this point in the history
Fix build and lint warnings
  • Loading branch information
havardholvik authored Nov 9, 2023
2 parents 935a6d2 + ffc1936 commit 4f0b5a0
Show file tree
Hide file tree
Showing 5 changed files with 3 additions and 18 deletions.
14 changes: 0 additions & 14 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -102,20 +102,6 @@ function MyCallUX( { roomUrl, localStream }) {

```

#### Usage with Vite development environment

There is a [known Vite issue](https://github.com/vitejs/vite/issues/1973) where modules trying to access `process.env` throw `Uncaught ReferenceError: process is not defined`.
This can be solved in `vite.config.js` with the following line:

``` javascript
export default defineConfig({
...rest,
define: {
'process.env': {}
},
});
```

#### Usage with Next.js

If you are integrating these React hooks with Next.js, you need to ensure your
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@whereby.com/browser-sdk",
"version": "2.0.0-alpha28",
"version": "2.0.0-beta3",
"description": "Modules for integration Whereby video in web apps",
"author": "Whereby AS",
"license": "MIT",
Expand Down
1 change: 1 addition & 0 deletions rollup.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ module.exports = [
{
input: "src/lib/react/index.ts",
output: [{ file: "dist/react/index.d.ts", format: "es" }],
external: ["@whereby/jslib-media/src/webrtc/RtcManager"],
plugins: [dts()],
},
{
Expand Down
2 changes: 0 additions & 2 deletions src/lib/__tests__/LocalMedia.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@ Object.defineProperty(navigator, "mediaDevices", {
value: mockMediaDevices,
});

const mockedMediaDevices = jest.mocked(navigator.mediaDevices);

describe("LocalMedia", () => {
describe("constructor", () => {
describe("when passing constraints", () => {
Expand Down
2 changes: 1 addition & 1 deletion src/lib/api/credentialsService/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import ChromeStorageStore from "../modules/ChromeStorageStore";
import LocalStorageStore from "../modules/LocalStorageStore";
import ApiClient from "../ApiClient";
import localStorage from "../localStorageWrapper";
import { Credentials } from "..";
import Credentials from "../Credentials";

/**
* Events triggered by this service
Expand Down

0 comments on commit 4f0b5a0

Please sign in to comment.