-
Notifications
You must be signed in to change notification settings - Fork 3
Restructure embedded examples repo #2
Restructure embedded examples repo #2
Conversation
CX-753 Restructure embedded-examples repo
Restructure https://github.com/whereby/embedded-example to take different example projects
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, but, did you forget to add the second example, or did you just want to move the current example to a directory?
*/build | ||
|
||
# misc | ||
.DS_Store |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you are going to leave DS_Store in the root-level gitignore, maybe drop it from here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not think we should treat these sub-directory .gitignore
file with the connection to the root-level of this repo. My idea is that these example should be easily copy/clone from user, it can be self-maintainable.
For instance, user can use some bootstrap cli to use each example as starter repo like this, then it would be nice .gitignore
file works regardless root-level .gitignore
file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, good point. In that case, shouldn't we just drop the root-level .gitignore
, then? The skipping of .DS_Store
should probably be in a global ignore file anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. I can remove .DS_Store
in this case.
Oh, I see, it's in another PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I never approved this 😅
4d7450f
to
04e21cc
Compare
This PR fixes CX-753.
In order to have different embedded examples, restructure this repo to have individual example as its own project folder.