Skip to content
This repository has been archived by the owner on Apr 10, 2023. It is now read-only.

Restructure embedded examples repo #2

Merged
merged 3 commits into from
Aug 20, 2021

Conversation

br1anchen
Copy link
Contributor

@br1anchen br1anchen commented Aug 20, 2021

This PR fixes CX-753.
In order to have different embedded examples, restructure this repo to have individual example as its own project folder.

repo
│   README.md
|   .gitignore
└───nextjs-express
    |   README.md
    |   .gitignore
└───other-example

@br1anchen br1anchen requested a review from a team August 20, 2021 09:12
@linear
Copy link

linear bot commented Aug 20, 2021

CX-753 Restructure embedded-examples repo

Restructure https://github.com/whereby/embedded-example to take different example projects

@br1anchen br1anchen requested review from dianaantunes, estebanwb and a team and removed request for a team, dianaantunes and estebanwb August 20, 2021 09:12
Copy link
Contributor

@estebanwb estebanwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but, did you forget to add the second example, or did you just want to move the current example to a directory?

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
*/build

# misc
.DS_Store
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are going to leave DS_Store in the root-level gitignore, maybe drop it from here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think we should treat these sub-directory .gitignore file with the connection to the root-level of this repo. My idea is that these example should be easily copy/clone from user, it can be self-maintainable.
For instance, user can use some bootstrap cli to use each example as starter repo like this, then it would be nice .gitignore file works regardless root-level .gitignore file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, good point. In that case, shouldn't we just drop the root-level .gitignore, then? The skipping of .DS_Store should probably be in a global ignore file anyway.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I can remove .DS_Store in this case.

@estebanwb
Copy link
Contributor

Looks fine, but, did you forget to add the second example, or did you just want to move the current example to a directory?

Oh, I see, it's in another PR!

@br1anchen br1anchen requested a review from estebanwb August 20, 2021 11:58
Copy link
Contributor

@estebanwb estebanwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I never approved this 😅

@br1anchen br1anchen force-pushed the brianchen/cx-753-restructure-embedded-examples-repo branch from 4d7450f to 04e21cc Compare August 20, 2021 13:14
@br1anchen br1anchen merged commit dc3e6c4 into main Aug 20, 2021
@br1anchen br1anchen deleted the brianchen/cx-753-restructure-embedded-examples-repo branch August 20, 2021 13:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants