Skip to content
This repository has been archived by the owner on Apr 10, 2023. It is now read-only.

nextjs-vercel: implement basic frontend UI #4

Merged
merged 24 commits into from
Aug 26, 2021

Conversation

br1anchen
Copy link
Contributor

@br1anchen br1anchen commented Aug 25, 2021

This PR fixes CX-745.

Using tailwindcss and react-hook-form to make basic UI for create/get/delete meeting in nextjs-serverelss-functions example.
Currently deployed on vercel: whereby-nextjs-demo.vercel.app

Screenshot 2021-08-25 at 11 38 26
Screenshot 2021-08-25 at 11 38 50

@br1anchen br1anchen requested a review from a team August 25, 2021 09:47
@linear
Copy link

linear bot commented Aug 25, 2021

CX-745 Implement basic frontend UIs for demo project

  • Setup Next.js project for demo frontend UIs
  • Use serverless functions in frontend client

@br1anchen br1anchen requested review from dianaantunes, sj-e2digital and a team and removed request for a team, dianaantunes and sj-e2digital August 25, 2021 09:47
Copy link
Contributor

@martrik martrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Two thoughts:

  1. Should we change the name of the folder so that it's shorter? What about nextjs? The fact that it uses a lambda function can be explained in the README.
  2. I think that we're missing an important bit here, which is actually embedding the meeting in an iframe. Are we planning on doing that as the next step? Perhaps similar to how Daily does it? https://github.com/daily-demos/prebuilt-ui/blob/main/assets/prebuilt-ui-demo.gif

nextjs-serverless-functions/pages/index.js Outdated Show resolved Hide resolved
@br1anchen
Copy link
Contributor Author

@martrik Thanks for review this.

Should we change the name of the folder so that it's shorter? What about nextjs? The fact that it uses a lambda function can be explained in the README.

Yeah, can rename the example to nextjs or nextjs-vercel since it is using vercel serverless functions.

I think that we're missing an important bit here, which is actually embedding the meeting in an iframe. Are we planning on doing that as the next step? Perhaps similar to how Daily does it? https://github.com/daily-demos/prebuilt-ui/blob/main/assets/prebuilt-ui-demo.gif

Yeah, I had though about using iframe and subscribe to any webhook events as well. But I think the first example maybe should be a bit simple. Including iframe might be enough, but then we need to check if startTime is within accessbile time for created room. We could add it in later PR.

@br1anchen br1anchen force-pushed the brianchen/cx-745-implement-basic-frontend-uis-for-demo branch from 3f4d308 to 1c4b50a Compare August 25, 2021 21:40
@br1anchen br1anchen changed the title nextjs-serverless-functions: implement basic frontend UI nextjs-vercel: implement basic frontend UI Aug 25, 2021
@br1anchen br1anchen merged commit 7baf4d2 into main Aug 26, 2021
@br1anchen br1anchen deleted the brianchen/cx-745-implement-basic-frontend-uis-for-demo branch August 26, 2021 09:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants