This repository has been archived by the owner on Apr 10, 2023. It is now read-only.
Add whereby logo as svg file in readme #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estebanwb
approved these changes
Aug 27, 2021
| <path d="m51.2641 6.28927c-1.1643 0-2.4356 1.2466-3.0282 2.43006v-2.55632h-.1691c-.7202 1.03538-2.4149 1.64835-4.0027 1.62654v.16874c.8687.25368 1.2921.95043 1.2921 2.17641v5.0288c0 .9722-.4234 1.7321-1.2702 2.1132v.1688h5.4638v-.1688c-.8686-.3799-1.2494-1.141-1.2494-2.1132v-5.91615c.3175-.40176.6776-.82418 1.101-.82418.7835 0 1.1011.95044 2.0756.95044.6776 0 1.3771-.54983 1.3771-1.47961-.0023-.92863-.7432-1.60473-1.59-1.60473z"></path><path d="m43.0884 9.28982c0-1.73214-1.7788-3.00054-4.0453-3.00054-3.4309 0-5.7607 2.95807-5.7607 6.06422 0 3.3805 2.5841 5.4099 5.1463 5.4099 2.0549 0 4.0453-1.2466 4.6597-3.4229l-.1485-.1263c-.6983 1.0354-1.9064 1.6059-3.1133 1.6059-1.5889 0-2.8809-.9091-3.4941-2.5357 3.2824-.5291 6.7559-1.4176 6.7559-3.99458zm-6.9043 3.48608c-.1266-.5073-.191-1.056-.191-1.6265 0-2.74688 1.1643-4.28963 2.6048-4.28963 1.1229 0 1.483.95044 1.483 1.96516 0 2.11207-1.9271 3.52857-3.8968 3.95097z"></path> | ||
| </g> | ||
| </svg> | ||
| <img src="./whereby-logo.svg" /> |
There was a problem hiding this comment.
Nice! I think we can actually simplify this whole block by just using the code below:
# Whereby Embedded examples
Haven't tested it so it might need tweaking, and the heading won't be centered... but it's a lot less code and looks more like what most people expect from a README, I think.
There was a problem hiding this comment.
Yeah, but the reason to use html is to apply center style in README.md though...
I would not say most people expect no styling in README in my opinion.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since github markdown does not support inline svg, change it to
whereby-logo.svgfile.