Stop disabled video track when Safari #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
havardholvik
force-pushed
the
havard/pan-243-camera-light-indicator-does-not-turn-off-in-safari
branch
from
aa10a60 to
881a7af
Compare
havardholvik
force-pushed
the
havard/pan-243-camera-light-indicator-does-not-turn-off-in-safari
branch
from
881a7af to
c897165
Compare
nandito
approved these changes
Oct 6, 2023
Previously, only Chrome needed to stop the video track to make the camera light turn off. Recent Safari releases have now opted to use the same logic, meaning we need to do the same for Safari on our end.
havardholvik
force-pushed
the
havard/pan-243-camera-light-indicator-does-not-turn-off-in-safari
branch
from
c897165 to
9ecddba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, only Chrome needed to stop the video track to make the camera light turn off. Recent Safari releases have now opted to use the same logic, meaning we need to do the same for Safari on our end.
See upcoming PWA PR for test instructions
📦 Published PR as canary version:
1.0.5--canary.13.6430264587.0✨ Test out this PR locally via:
npm install @whereby/jslib-media@1.0.5--canary.13.6430264587.0 # or yarn add @whereby/jslib-media@1.0.5--canary.13.6430264587.0