Replace Karma + Mocha with Jest #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
havardholvik
force-pushed
the
holvik/replace_karma_jest
branch
5 times, most recently
from
08a1fc9 to
3b61954
Compare
havardholvik
requested review from
nandito,
thyal,
sarahrose-ferris and
kevinwhereby
havardholvik
changed the title
havardholvik
force-pushed
the
holvik/replace_karma_jest
branch
2 times, most recently
from
e057ad8 to
b73b043
Compare
havardholvik
commented
Nov 1, 2023
havardholvik
commented
Nov 1, 2023
havardholvik
commented
Nov 1, 2023
havardholvik
force-pushed
the
holvik/replace_karma_jest
branch
2 times, most recently
from
374db8a to
35a3e0b
Compare
thyal
reviewed
Nov 1, 2023
I also dont like this output. I was wondering if we should take these log tweaks on in the separate task we have for the SDK to prevent logs in console. Maybe we just need to make the logging configurable from the calling environment....? |
To align with our other repos, replace the ageing Karma + Mocha setup in favour of Jest. Also makes logging configurable To avoid logs filling up test reports, and potentially end user consoles, make logging configurable. Defaults to the previous behaviour, meaning logging is enabled unless explicitly disabled.
havardholvik
force-pushed
the
holvik/replace_karma_jest
branch
from
dabaa18 to
bd47dd3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace Karma + Mocha with Jest.
📦 Published PR as canary version:
1.3.7--canary.30.6719332745.0✨ Test out this PR locally via:
npm install @whereby/jslib-media@1.3.7--canary.30.6719332745.0 # or yarn add @whereby/jslib-media@1.3.7--canary.30.6719332745.0