Replace the 3rd party assert lib
#32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is going to replace the 3rd party assert lib.
...and `yarn remove` the `assert` lib.
nandito
deleted the
nandor/pan-502-remove-the-assert-lib-from-jslib-media
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have encountered bundle failures on fresh browser-sdk installations with an error message stating, "Could not find module in path: 'assert/assert.js'."
Since we do not heavily depend on this package, we can resolve the issue by replacing the third-party installation.
We will accomplish this by incorporating the relevant assert functions from https://github.com/browserify/commonjs-assert into our repository.
📦 Published PR as canary version:
1.4.2--canary.32.6769211916.0✨ Test out this PR locally via:
npm install @whereby/jslib-media@1.4.2--canary.32.6769211916.0 # or yarn add @whereby/jslib-media@1.4.2--canary.32.6769211916.0