feat: add VCF extension inference support#207
Open
VedantMadane wants to merge 1 commit intowheretrue:mainfrom
Open
feat: add VCF extension inference support#207VedantMadane wants to merge 1 commit intowheretrue:mainfrom
VedantMadane wants to merge 1 commit intowheretrue:mainfrom
Conversation
- Allow file_extension parameter in VCFReadOptions constructor - Pass file_extension to ListingVCFTableOptions in From impl - Add test for VCF extension inference from file path This enables reading VCF files without explicitly specifying the file extension or compression type - they are inferred from the path. Contributes to wheretrue#154
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #154
Adds support for inferring VCF file type from file extension, completing the extension inference feature for all major bioinformatics formats.
Changes
Format Support Status
Testing