Skip to content

Commit

Permalink
Update logger
Browse files Browse the repository at this point in the history
- Updated README instructions (wrong reference to morituri)
- EAC's defeat cache status value can only be 'Yes' or 'No' (removed 'Unknown')
- This logger now includes its version number into the generated reports
  • Loading branch information
JoeLametta committed Oct 19, 2018
1 parent a8a1b8c commit 80b3160
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 17 deletions.
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,5 @@ install:
- pip install flake8

script:
- flake8 --benchmark --statistics --exclude="setup.py"
- flake8 --benchmark --statistics
- python setup.py bdist_egg
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ To use this plugin:

```bash
export XDG_DATA_HOME=${XDG_DATA_HOME:-"${HOME}/.local/share"}
mkdir -p $XDG_DATA_HOME/whipper/plugins
cp dist/morituri_*egg $XDG_DATA_HOME/whipper/plugins
mkdir -p "$XDG_DATA_HOME/whipper/plugins"
cp "dist/whipper_plugin_eaclogger*.egg" "$XDG_DATA_HOME/whipper/plugins"
```

* verify that it gets recognized:
Expand Down
9 changes: 4 additions & 5 deletions eaclogger/logger/eac.py
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,8 @@ def logRip(self, ripResult, epoch):

# Ripper version
# ATM differs from EAC's typical log line
lines.append("whipper version %s (eac logger)" % whipper.__version__)
lines.append("whipper version %s "(eac logger 0.3.1)" % (
whipper.__version__))
lines.append("")

# Rip date
Expand All @@ -76,11 +77,9 @@ def logRip(self, ripResult, epoch):
# Extra line (not included in EAC's logfiles)
lines.append("Use cdparanoia mode : Yes (cdparanoia %s)" % (
ripResult.cdparanoiaVersion))
defeat = "Unknown"
if ripResult.cdparanoiaDefeatsCache is True:
defeat = "No"
if ripResult.cdparanoiaDefeatsCache:
defeat = "Yes"
if ripResult.cdparanoiaDefeatsCache is False:
defeat = "No"
lines.append("Defeat audio cache : %s" % defeat)
lines.append("Make use of C2 pointers : No")
lines.append("")
Expand Down
18 changes: 9 additions & 9 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,15 @@

setup(
name="whipper-plugin-eaclogger",
version="0.3.0",
description="""A logger plugin for whipper which provides EAC style log reports""",
version="0.3.1",
description="Logger plugin for whipper which provides EAC style reports",
author="JoeLametta, superveloman",
maintainer="JoeLametta",
url="https://github.com/whipper-team/whipper-plugin-eaclogger",
packages=[
"eaclogger",
"eaclogger.logger"],
entry_points="""
[whipper.logger]
eac = eaclogger.logger.eac:EacLogger
""")
packages=["eaclogger", "eaclogger.logger"],
entry_points={
"whipper.logger": [
"eac = eaclogger.logger.eac:EacLogger"
]
}
)

0 comments on commit 80b3160

Please sign in to comment.