Skip to content

Implement Store via sqlite #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Mar 15, 2025
Merged

Implement Store via sqlite #301

merged 18 commits into from
Mar 15, 2025

Conversation

boxdot
Copy link
Collaborator

@boxdot boxdot commented Jan 28, 2025

Partially based on #287

Manually tested with gurk.

@boxdot boxdot requested a review from gferon March 12, 2025 10:53
@boxdot boxdot marked this pull request as ready for review March 12, 2025 10:53
@gferon gferon mentioned this pull request Mar 13, 2025
@Schmiddiii
Copy link
Contributor

The .sqlx should probably be gitignored. See also this discussion.

@boxdot
Copy link
Collaborator Author

boxdot commented Mar 14, 2025

The .sqlx should probably be gitignored. See also this discussion

I think in their situation (in sqlx repo), the ignored .sqlx directory actually contains some artifacts created by their tests. In our case, we actually want to include those files. Otherwise, it is not possible to compile the code without setting up a database.

@Schmiddiii
Copy link
Contributor

I think in their situation (in sqlx repo), the ignored .sqlx directory actually contains some artifacts created by their tests. In our case, we actually want to include those files. Otherwise, it is not possible to compile the code without setting up a database.

I forwarded the question as a discussion in the sqlx repository. Let's see what they have to say regarding adding .sqlx in the .gitignore.

@Schmiddiii
Copy link
Contributor

Seems like you are right adding the .sqlx to git. I'm still not a huge fan of it, but accept defeat.

@gferon
Copy link
Collaborator

gferon commented Mar 15, 2025

Seems like you are right adding the .sqlx to git. I'm still not a huge fan of it, but accept defeat.

It's important for CI verification. We can also add an entry in the .gitattributes file to make sure the diff is never displayed?

@Schmiddiii
Copy link
Contributor

Sounds good.

@gferon
Copy link
Collaborator

gferon commented Mar 15, 2025

Excellent! Thank you very much!

@gferon gferon enabled auto-merge (squash) March 15, 2025 19:19
@gferon gferon merged commit 5328d27 into whisperfish:main Mar 15, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants