Add preliminary support for First-Order Logic #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is taken from the external repository paulotguerra/pylogics-extras@6848d5f, and the copyright holder is the author of this commit: Paulo T. Guerra <paulodetarso@ufc.br> (@paulotguerra)
|
I do confirm the repective licensing change. |
|
Merging this now, we can continue working on this feature on separate PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR adds preliminary support for First-Order Logic and an implementation of natural deduction.
In particular, the added files in commit 3c49b23 are taken from the external repository paulotguerra/pylogics-extras@6848d5f, and the copyright holder is the author of that commit (Paulo T. Guerra paulodetarso@ufc.br (@paulotguerra)). The commit 3c49b23 is authored by @paulotguerra to recognize the authorship of the code (but it has been committed by @marcofavorito for practical purposes).
Paulo will be added as a contributor to the project and, therefore, will hold the copyright. The license will implicitly reflect this using the notice "Copyright (c) 2021-2024 The Pylogics contributors" (see #139). The fine-grained information on the contributions is stored in the Git history of the project.
The code needs relicensing of his code with the MIT license rather than the GPL (see
pylogics-extrasLICENSE). This is needed since after #139 the Pylogics' LICENSE is the MIT License, which is incompatible with GPL. This has been agreed upon in private communication with @paulotguerra, and he can confirm this licensing change on his code by commenting on this PR.