Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: migrate to svelte 5 #112

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
+1,841 −4,392
Open

Feat: migrate to svelte 5 #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
37a788c
chore(deps): update svelte and related dependencies to latest versions
Michael-Liendo Dec 9, 2024
2f47be5
chore(deps-dev): upgrade Svelte and related packages; refactor Notifi…
Michael-Liendo Dec 9, 2024
0730475
chore(deps): update Svelte and development dependencies to latest ver…
Michael-Liendo Dec 9, 2024
c54ec8f
chore(deps-dev): modify import path for render function to support Sv…
Michael-Liendo Dec 9, 2024
e0821a6
chore(docs): update README to improve NotificationList integration an…
Michael-Liendo Dec 9, 2024
d5758c9
refactor(NotificationList): change Position enum to const and align t…
Michael-Liendo Dec 10, 2024
635701f
fix(tests): update NotificationList tests to use props for positional…
Michael-Liendo Dec 10, 2024
9a25f8e
fix(page): adjust import path for NotificationList to include index.j…
Michael-Liendo Dec 10, 2024
9278112
fix(config): add conditions for VITEST environment and fix formatting…
Michael-Liendo Dec 10, 2024
e9771ce
fix(deps): add @types/node types to devDependencies for improved type…
Michael-Liendo Dec 10, 2024
3346a70
feat(ci): add npm check step to CI workflow for ensuring code quality…
Michael-Liendo Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@ jobs:

- name: Install Dependencies
run: npm ci

- name: Check
run: npm run check

- name: Build
run: npm run build
17 changes: 9 additions & 8 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,14 +39,15 @@ npm install @whizzes/svelte-notifications
};
</script>

<button on:click="{success}">Append Success</button>

<!-- Notifications provider -->
<NotificationList position="{Position.BottomRight}" let:notification>
<li>
<strong>{notification.title}</strong>
<p>{notification.message}</p>
</li>
<button onclick={success}> Append Success </button>

<NotificationList>
{#snippet children({ notification })}
<li>
<strong>{notification.title}</strong>
<p>{notification.message}</p>
</li>
{/snippet}
</NotificationList>
```

Expand Down
Loading
Loading