support image selectable (pool-agent) #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gamoutatsumi
force-pushed
the
image_selectable_pool_agent
branch
2 times, most recently
from
537d805 to
284e8aa
Compare
gamoutatsumi
force-pushed
the
image_selectable_pool_agent
branch
from
2207e30 to
8c48316
Compare
gamoutatsumi
force-pushed
the
image_selectable_pool_agent
branch
from
8c48316 to
b592f26
Compare
whywaita
reviewed
Dec 17, 2024
| for version, config := range a.Config { | ||
| toDelete := []string{} | ||
| for rtName, rt := range a.ResourceTypesMap { | ||
| current := a.countPooledInstances(s, rtName, version) |
There was a problem hiding this comment.
nit: this loop is too big. We need to refactor it (e.g. split function for testable)
whywaita
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #44
changess: