feat: relax typing_extensions version constraint #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egormkn
force-pushed
the
relax-deps-version-constraints
branch
from
b8f8c0d
to
432c1a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I wanted to use Reacton in a project where the version of typing_extensions is pinned to 3.7.4.1 (python3-typing-extensions package from Ubuntu 20.04). However, due to ParamSpec usage, reacton requires at least 4.1.1. I suggest to relax the requirements, as missing type definition does not break anything.
Here I used a simple try-except to set type alias to ellipsis on failed import. Not entirely sure if it is correct as documentation specifies a literal ellipsis as a possible type argument for Callable, but with CPython 3.6+ this works fine.