Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Python 3.8, update CI #752

Closed
wants to merge 3 commits into from
Closed

Require Python 3.8, update CI #752

wants to merge 3 commits into from

Conversation

EwoutH
Copy link
Contributor

@EwoutH EwoutH commented Aug 26, 2024

Python 3.6 and 3.7 have both been end-of-life for over a year. This PR starts requiring Python 3.8 and higher for Solara. CI and test code is modified in sync.

@EwoutH
Copy link
Contributor Author

EwoutH commented Aug 26, 2024

Seems all 3.12 tests get stuck on a similar issue:

ImportError while loading conftest '/home/runner/work/solara/solara/tests/conftest.py'.
tests/conftest.py:5: in <module>
    from dotenv import load_dotenv
E   ModuleNotFoundError: No module named 'dotenv'

Python 3.6 and 3.7 have both been end-of-life for over a year. This PR starts requiring Python 3.8 and higher for Solara. CI and test code is modified in sync.
@EwoutH
Copy link
Contributor Author

EwoutH commented Aug 26, 2024

It seems it just isn't installed when imported here:

from dotenv import load_dotenv

Weird that it happens on 3.12 only. But where should I specify it as an required package or install it?

@EwoutH
Copy link
Contributor Author

EwoutH commented Aug 30, 2024

More complex than I thought, and unfortunately no time to debug it. Closing.

(I would still recommend dropping Python 3.6 and 3.7)

@EwoutH EwoutH closed this Aug 30, 2024
@maartenbreddels
Copy link
Contributor

It is weird, python-dotenv is a dependency. Might pick up the wrong Python env?

I'd rather extend the Python versions, and only drop the older ones if there are strong reasons (we saw Python 3.6 envs in our consultancy work, and we couldn't do the work if we didn't support it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants