fix: vscode fails to load scripts from _solara/cdn #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @iisakkirotko and the rest of your teammates on |
We fetch from an online cdn instead. Implements the same method as in 7238a37 for vegalite for other vue template components.
iisakkirotko
force-pushed
the
08-30-fix_vscode_fails_to_load_scripts_from__solara_cdn
branch
from
25d327b
to
8b48dd7
Compare
maartenbreddels
requested changes
Aug 30, 2024
solara/components/markdown.py
Outdated
| @@ -76,6 +76,12 @@ def _markdown_template( | |||
| html, | |||
| style="", | |||
| ): | |||
| cdn = r"null" | |||
There was a problem hiding this comment.
Suggested change
| cdn = r"null" | |
| cdn = None |
There was a problem hiding this comment.
Let me know if you agree with my solution - I changed cdn to None by default, and instead filter it out later:
this.cdn = """
+ (rf"'{cdn}'" if cdn is not None else r"null")
+ r""";There was a problem hiding this comment.
yeah, this makes more sense 👍
Co-Authored-by: maartenbreddels <maartenbreddels@gmail.com>
This was referenced Aug 30, 2024
|
Related to #488 |
|
And #480 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #761.