docs: ensure twitter and og meta tags for all routes #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @iisakkirotko and the rest of your teammates on |
Merged
solara/website/pages/__init__.py
Outdated
Comment on lines
262
to
266
| Title(title="Solara: Example Apps") | ||
| return children[0] | ||
| if route_current is not None and route_current.path == "/": | ||
| Title(title="Solara: Build high-quality web applications in pure Python") | ||
| return Home() |
There was a problem hiding this comment.
Hmm, this won't work, because the return 'overrides' the auto collecting. Not sure if the layout messes up when we have it without the return (because we get a column around it).
Maybe
with solara.Div():
Title(..)
Home()There was a problem hiding this comment.
Removing the return works for the most part, but we run into #626 in a particularly bad way.
There was a problem hiding this comment.
See 3ebea2d for a solution
There was a problem hiding this comment.
Works now, although the diff looks terrible.
iisakkirotko
force-pushed
the
09-13-docs_ensure_meta_tags_for_all_routes
branch
from
823dcbc
to
d6572da
Compare
iisakkirotko
force-pushed
the
09-13-docs_fixes_to_styling
branch
from
af9c2a7
to
87c0864
Compare
iisakkirotko
force-pushed
the
09-13-docs_ensure_meta_tags_for_all_routes
branch
2 times, most recently
from
c08fea6
to
7a29367
Compare
Merge activity
|
iisakkirotko
changed the base branch from
09-13-docs_fixes_to_styling
to
graphite-base/787
iisakkirotko
force-pushed
the
09-13-docs_ensure_meta_tags_for_all_routes
branch
from
7a29367
to
7e76104
Compare
maartenbreddels
temporarily deployed
to
09-13-docs_ensure_meta_tags_for_all_routes - solara-stable PR #787
Render
Destroyed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.