Skip to content

Commit

Permalink
Change the Commons test file (#729)
Browse files Browse the repository at this point in the history
The Test.svg file gets changed by people sometimes, causing the
svgtranslate CI tests to fail, so to avoid issues this switches to a
file that's specifically labelled as being used for this purpose.

Also fix an indent in ci.yml.
  • Loading branch information
samwilson authored Feb 29, 2024
1 parent 69bb1e8 commit 3682a4e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
- name: Build
run: |
npm run build
npm run build
- name: Test
run: |
Expand Down
4 changes: 2 additions & 2 deletions tests/Controller/TranslateControllerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ class TranslateControllerTest extends WebTestCase
public function testExists(): void
{
$client = static::createClient();
$crawler = $client->request('GET', '/File:Test.svg');
$crawler = $client->request('GET', '/File:SVG_Translate_test_-_valid.svg');
$response = $client->getResponse();
static::assertEquals(200, $response->getStatusCode());
static::assertStringContainsString('Test.svg', $crawler->filter('h1')->text());
static::assertStringContainsString('SVG Translate test - valid.svg', $crawler->filter('h1')->text());
}

public function testNonSvgHandling(): void
Expand Down

0 comments on commit 3682a4e

Please sign in to comment.