Improve error handling on routes and tasks #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbarnabee
changed the title
Removed extraneous print() messages Clarified results so that the workflow is clearer Attempted to catch additional exceptions on db update failure
nbarnabee
force-pushed
the
improve_error_handling
branch
from
ec1edf6 to
e5225b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the course of investigating T333016 I realized that my error handling on the API routes was extremely haphazard. I've now wrapped all of the routes in try/except blocks.
There is still much room for improvement, however; right now I'm only looking for the "catch-all" error
SQLAlchemyError, and my handling of it is "minimal," to put it kindly.I also made some tweaks to how the async tasks handle errors (though I'm finding it difficult to test my changes) and updated their results to better indicate what's happening.